FEATURE/HCMPRE-1649 : help text and checklist create call order corrected #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThe pull request introduces a new Changes
Possibly related PRs
Suggested Reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🧰 Additional context used📓 Path-based instructions (3)health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/CreateChecklist.js (1)Pattern health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/ViewChecklist.js (1)Pattern health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/UpdateChecklist.js (1)Pattern 🪛 Biome (1.9.4)health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/CreateChecklist.js[error] 456-456: This let declares a variable that is only assigned once. 'roleTemp' is never reassigned. Safe fix: Use const instead. (lint/style/useConst) [error] 457-457: This let declares a variable that is only assigned once. 'helpTextCode' is never reassigned. Safe fix: Use const instead. (lint/style/useConst) health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/UpdateChecklist.js[error] 405-405: This let declares a variable that is only assigned once. 'helpTextCode' is never reassigned. Safe fix: Use const instead. (lint/style/useConst) 🔇 Additional comments (5)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/CreateChecklist.js(5 hunks)health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/UpdateChecklist.js(6 hunks)health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/ViewChecklist.js(3 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/ViewChecklist.js (1)
Pattern **/*.js: check
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/CreateChecklist.js (1)
Pattern **/*.js: check
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/UpdateChecklist.js (1)
Pattern **/*.js: check
🪛 Biome (1.9.4)
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/CreateChecklist.js
[error] 455-455: This let declares a variable that is only assigned once.
'roleTemp' is never reassigned.
Safe fix: Use const instead.
(lint/style/useConst)
[error] 456-456: This let declares a variable that is only assigned once.
'helpTextCode' is never reassigned.
Safe fix: Use const instead.
(lint/style/useConst)
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/UpdateChecklist.js
[error] 404-404: This let declares a variable that is only assigned once.
'helpTextCode' is never reassigned.
Safe fix: Use const instead.
(lint/style/useConst)
🔇 Additional comments (7)
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/ViewChecklist.js (2)
27-27: Use of new state variable looks good.
No issues found in introducing the new helpText state variable.
47-47: Optional fallback check for deeply nested attributes.
While this snippet uses optional chaining, consider gracefully handling scenarios where the fields array may be empty or undefined, to avoid potential runtime errors.
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/CreateChecklist.js (2)
46-46: Help text state initialization is fine.
This addition aligns well with the new help text functionality.
432-433: Inclusion of helpText in payload is consistent with requirements.
Good job ensuring the help text is persisted in the checklist data structure.
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/UpdateChecklist.js (3)
41-41: Help text state initialization is valid.
No issues found with introducing helpText in the component state.
77-77: Optional fallback for deeply nested property.
Similar to other components, consider a defensive check to prevent potential errors if additionalFields or fields are missing.
380-381: Consistency in payload structure.
Ensuring helpText is included here maintains consistency with the creation flow.
...web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/ViewChecklist.js
Show resolved
Hide resolved
...b/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/CreateChecklist.js
Show resolved
Hide resolved
...b/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/CreateChecklist.js
Show resolved
Hide resolved
...b/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/UpdateChecklist.js
Show resolved
Hide resolved
...b/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/UpdateChecklist.js
Show resolved
Hide resolved
jagankumar-egov
approved these changes
Jan 29, 2025
jagankumar-egov
changed the title
jagankumar-egov
added a commit
that referenced
this pull request
Feb 14, 2025
…Payments v0.1.0 (#2217) * BUGFIX/HCMPRE-1547 updated workflow error message to generic code (#2005) updated workflow error message to generic code Co-authored-by: Jagankumar <[email protected]> * BUGFIX/HCMPRE-1246 :: boundary related issue (#1998) * validation from ui (#1981) * validation from ui * empty top rows considered * info card added for error in place of toast * review changes * file name added * file name added * Updated the branch name validation (#1997) * Update README.md * Updated the branch name validation * Updated the branch name validator to have title check as well (#2002) * review changes --------- Co-authored-by: Jagankumar <[email protected]> * BUGFIX/ISSUE-2007 Build issue fix for #2007 (#2008) * Build issue fix for #2007 * import issue fix --------- Co-authored-by: NabeelAyubee <[email protected]> * BUGFIX/HCMPRE-1585 fixed tootltip icon position according to the label (#2010) * Update UserManagement.js (#2017) Co-authored-by: Nipun Arora <[email protected]> * Feature/HCMPRE-1234: adding mapping screen for facility and user screen (#2012) * adding mapping screen for facility and user screen * Update health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadDataMappingWrapper.js Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: NabeelAyubee <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * updated core version (#2020) * Bugfix/hcmpre 1583 (#2021) * Update MicroplanSearch.js * Pagination issues --------- Co-authored-by: Nipun Arora <[email protected]> * BUGFIX/HCMPRE-1634: fix for versions (#2024) * Revert "Bugfix/hcmpre 1583 (#2021)" This reverts commit 201a0ce. * BUGFIX/HCMPRE-1634 Revert ing"updated core version (#2020)" * BUGFIX/HCMPRE-1583 fixes --------- Co-authored-by: Swathi-eGov <[email protected]> * FEATURE/HCMPRE-1634:Fixed all the version updates (#2026) FEATURE/HCMPRE-1634: Fixed all the version updates * FIX : Branch name validator fixed Reference #2042 Sample Ticket for reference #2042 * FEATURE/HCMPRE-1644 : Changed download template name (#2035) FEATURE/HCMPRE-1644: Changed download template name Co-authored-by: Jagankumar <[email protected]> * BUGFIX/HCMPRE-1505 : Updated Core Version To Fix Validation Issue on … (#2047) BUGFIX/HCMPRE-1505 : Updated Core Version To Fix Validation Issue on Profile Update * FEATURE/HCMPRE-814: Added geojson view and edit (#2013) * added geojson view and edit * resolved pr comments --------- Co-authored-by: nabeelmd-eGov <[email protected]> Co-authored-by: Jagankumar <[email protected]> * BUGFIX/HCMPRE-1243: fixes currentKey (#2052) * fixes current key * fixes --------- Co-authored-by: NabeelAyubee <[email protected]> * FEATURE/HCMPRE-1625 last modified date added in campaign search and checklist search screens (#2044) * last modified date added in campaign search and checklist search screens * lat modified date corrected --------- Co-authored-by: Jagankumar <[email protected]> * BUGFIX/HCMPRE-1418 : Fixed IRS value NAN issue (#2055) Co-authored-by: Jagankumar <[email protected]> * BUGFIX/HCMPRE-1243: added check for empty upload (#2056) * fixes current key * fixes * added check --------- Co-authored-by: NabeelAyubee <[email protected]> * FEATURE/HCMPRE-1624 : added alert, fixed localisation on checklist & added more date info on Hierarchy (#2054) * showcase review points * logs rmoved --------- Co-authored-by: Jagankumar <[email protected]> * HCMPRE-1717::PAYMENTS Module setup (#2053) * PAYMENTS Module setup * updated module index file * updated comments * HCMPRE-1717:: Removed other modules dependency from Payments * added static view screen * Updated dependencies * Updated Roles and label for Payments Card * HCMPRE-1717:: Payments Base Module Setup * Resolved code rabbit comments * Update package.json * Rename view_attendance.js to ViewAttendance.js * Update attendanceManagementTable.js * Update build-config.yml * Update Module.js * Update Module.js --------- Co-authored-by: rachana-egov <[email protected]> Co-authored-by: Jagankumar <[email protected]> * FEATURE/HCMPRE-1717 :: added payment module build (#2059) * FEATURE/HCMPRE-1717 :: added payment module build * Update build-config.yml * BUGFIX/HCMPRE-1717 :: Health Payments Module Build issue fix (#2060) Health Payments Module Build issue fix * BUGFIX/HCMPRE-1283: added the config for campaign creation from microplan * BUGFIX/HCMPRE-1717 :: FIxed the build config file (#2062) * BUGFIX/HCMPRE-15830 : Fixed checkbox click area (#2064) Css changes * BUGFIX/HCMPRE-1730 & HCMPRE-1731 (#2070) * BUGFIX/HCMPRE-1730 & HCMPRE-1731 * fixes --------- Co-authored-by: NabeelAyubee <[email protected]> * Added css for payment module (#2079) Co-authored-by: rachana-egov <[email protected]> * BUGFIX/HCMPRE-1730: Fixes pagination in mapping table (#2078) * BUGFIX/HCMPRE-1730 & HCMPRE-1731 * fixes * BUGFIX/HCMPRE_1730: Fix pagination --------- Co-authored-by: NabeelAyubee <[email protected]> * FEATURE/HCMPRE-1209 : Added co-del project type (#2088) FEATURE/HCMPRE-1209 : Added co-del project type Co-authored-by: Jagankumar <[email protected]> * FEATURE/HCMPRE-1789 : Draft Flow (#2093) * changes to createUpdatePlan * Changes to UI, createUpdatePlan * Putting the Hierarchy near the name * Loc change * Resolved comments * Null check for Hierarchy level * Changes * Indirectly Mutating planObject * changes * changes --------- Co-authored-by: Abishek <[email protected]> * FEATURE/HCMPRE-1787 : Untagging all the current users if boundary is (#2092) * FEATURE/HCMPRE-1787 : Untagging all the current users if boundary is changed during setup * FEATUTE/HCMPRE-1787 : Added different error cases * FEATURE/HCMPRE-1710: Accessibility dropdown for planInbox with plan integration and apply filter (#2091) * Adding filters * Working Filter Search * InboxFilter Changes * removing console.log * Css package update * changes * changes * changes * changes * changes * A lot of changes * changes * changes * changes * uniform payload structure * FEATURE/HCMPRE-1712: Facility Dropdown for plan Inbox (#2096) * Adding filters * Working Filter Search * InboxFilter Changes * removing console.log * Css package update * changes * changes * changes * changes * changes * A lot of changes * changes * changes * changes * uniform payload structure * Adding Facility Dropdown * code replacing name attribute * Loader changes * comments resolved * Loader change * Id to id * BUGFIX/HCMPRE-1810: Fix issue for next page in user tagging (#2104) * for clickng on save and next * remove console * FEATURE/HCMPRE-1706: Plan Inbox updates and draft flow changes (#2109) * updated plan inbox * Update createUpdatePlanProject.js * formatted createupdateplanproject * BUGFIX/HCMPRE-1776 : Added UI/UX Master changes (#2110) * FEATURE/HCMPRE-1681: Handled the case where capacity is 0 and tested full flow (#2111) handled the case where capacity is 0 and tested full flow * BUGFIX/HCMPRE-1209 changes in the project type code (#2116) * HCMPRE-1766: App Configuration Screen Setup (#2117) * HCMPRE-1766: Added AppScreenConfiguration Feature screen * added enhancement in app configuration * added app configuration link * added tag component in mapping * package upgrade --------- Co-authored-by: NabeelAyubee <[email protected]> * FEATURE/HCMPRE-1713: PopInbox and filtering integration (#2108) * PopInbox and facilityId search in planInbox * Localization * Chages to CSS and removing filter * Changes to facility filter and security Question * css package update * facilityId removed * Resolved comments, made payload to facilityId * component package update * FEATURE/HCMPRE-1852 :: Consolidated Common UI (#2120) * added change for common * Updated the readme content * revert * added build configs * Update buildCommonConsole.yml * Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * FEATURE/HCMPRE-1704 : Removing current validation from assumptions an… (#2122) * FEATURE/HCMPRE-1704 : Removing current validation from assumptions and making sure the flow works as expected( for mixed strat, regis and dist can be same) * FEATURE/HCMPRE-1704 : Review updates * HCMPRE-1766: User Mapping Issue fix (#2119) * User Mapping issue fixes * fix lowest Hierarchy boundary selection * fi localisation code --------- Co-authored-by: NabeelAyubee <[email protected]> * BUGFIX/HCMPRE-1584: Disable planSearch for popInbox and CSS for dropdown (#2123) * BUGFIX/HCMPRE-1866 : Updated versions (#2128) * FEATURE/HCMPRE-0000 : Fix for serach query in user tagging screen (#2132) * FEATURE/HCMPRE-1826 : Fixed 0 capacity validation from microplan (#2137) * FEATURE/HCMPRE-1826 : Fixed 0 capacity validation from microplan * validation method change * BUGFIX/HCMPRE-1944: TotalCount UI issue in planIbox (#2138) * useEffect updated * CountAssignToAll issue in planInbox * BUGFIX/HCMPRE-1955 : updated versions of core and libraries (#2144) updated versions of core and libraries * BUGFIX/HCMPRE-1826 : Enhanced microplan validation (#2147) Co-authored-by: Jagankumar <[email protected]> * FEATURE/HCMPRE-1852 :: Consolidated Common UI removing other modules(#2120) * FEATURE/HCMPRE-2207 : removed the hard coded project types (#2157) * BUGFIX/HCMPRE-1242: Status active/inactive and pagination bug fix (#2160) HCMPRE-1242: Status active/inactive and pagination bug fix Co-authored-by: NabeelAyubee <[email protected]> * BUGFIX/HCMPRE-1243: user mapping pagination issue fix and error toast added for api error (#2162) Co-authored-by: NabeelAyubee <[email protected]> * FEATURE/HCMPRE-1852: Fixes of version in consolidated UI (#2163) * Update build-config.yml * Update App.js * Update package.json * Update package.json * fix of landing pacge * Update build-config.yml * FEATURE/HCMPRE-2215 : UI Code cleanup (#2161) * FEATURE/HCMPRE-1852: Added other optimisations for common build(#2163) * add/edit mappings (#2152) * add/edit mappings * edit and delete feature added * classname corrected * Update health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js --------- Co-authored-by: nabeelmd-eGov <[email protected]> Co-authored-by: NabeelAyubee <[email protected]> * BUGFIX/HCMPRE-1243: User Mapping Table CSS fix (#2168) Co-authored-by: NabeelAyubee <[email protected]> * FEATURE/HCMPRE-1438 : Health Payments v0.1 Module (#2136) * removed hcm from store * added view attendance screen * added alert pop up, table for view and edit attendance * updated module.js file * added success screen and updated breadcrumbs * fixing table component * HCMPRE-1717:: Load and store project details on Payments module initi… (#2065) HCMPRE-1717:: Load and store project details on Payments module initialization * added input component in table for editing attendance * HCM-1646::Payment inbox attendance (#2067) attendance inbox in progress * updated table with static data and fields with attendance data * updated breadcrumbs * fixed edit attendance calls * updated css * fixed nevigation issue * updated css version * Payment inbox attendance (#2072) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * updated api calls for create and update flow and added disabled action condition * fixed back button in view screen * Payment inbox attendance (#2073) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * Update filter_section.js --------- Co-authored-by: rachana-egov <[email protected]> * added workflow in api calls * removed comments * updated api base point * Payment inbox attendance (#2074) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * Payment inbox attendance (#2075) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * Payment inbox attendance (#2076) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * removed debugger * variable name changed * inbox css fix * added module for boundary localization * added session storage for individual * added individual in session storage * fixed project search issue * Payment inbox attendance (#2080) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * removed debugger * variable name changed * tab section functionlity added * attendance register param changed * Payment inbox attendance (#2082) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * removed debugger * variable name changed * tab section functionlity added * attendance register param changed * localization code and table value changed * Updated hierarchy type for Payments Testing * integrated with apis * added create api * added validation for APPROVAL * fixed extra call issue * fixed issue * Payment inbox attendance (#2084) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * removed debugger * variable name changed * tab section functionlity added * attendance register param changed * localization code and table value changed * inbox pagination and status register count fixed * table component css style changed * padding removed from table style * console removed * added loading for mutation * translator funtion added * started with static screens for bills * Payment inbox attendance (#2090) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * removed debugger * variable name changed * tab section functionlity added * attendance register param changed * localization code and table value changed * inbox pagination and status register count fixed * table component css style changed * padding removed from table style * console removed * HCMPRE-1774: point-1 project drop down is put in the filter section and search section is not required as per last demo * updated default pagination * fixed small css issues * Payment inbox attendance (#2094) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * removed debugger * variable name changed * tab section functionlity added * attendance register param changed * localization code and table value changed * inbox pagination and status register count fixed * table component css style changed * padding removed from table style * console removed * HCMPRE-1774: point-1 project drop down is put in the filter section and search section is not required as per last demo * fliter boundary dropdown in progress * staffName key changed for attendance mark by * updated view attendance screen * removed other links * Payment inbox attendance (#2095) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * removed debugger * variable name changed * tab section functionlity added * attendance register param changed * localization code and table value changed * inbox pagination and status register count fixed * table component css style changed * padding removed from table style * console removed * HCMPRE-1774: point-1 project drop down is put in the filter section and search section is not required as per last demo * fliter boundary dropdown in progress * staffName key changed for attendance mark by * bug fixes * removed logs * code comment added and status put in the constant file * Updated Payments Module Initialization to a single hook * added bill search api * updated search bill params * Payment inbox attendance (#2099) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * removed debugger * variable name changed * tab section functionlity added * attendance register param changed * localization code and table value changed * inbox pagination and status register count fixed * table component css style changed * padding removed from table style * console removed * HCMPRE-1774: point-1 project drop down is put in the filter section and search section is not required as per last demo * fliter boundary dropdown in progress * staffName key changed for attendance mark by * bug fixes * code comment added why not used inboxsearch composer * boundary service made dynamic * added condition to boundary filter * updated bill inbox * fixed my bills screen * Payment inbox attendance (#2100) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * removed debugger * variable name changed * tab section functionlity added * attendance register param changed * localization code and table value changed * inbox pagination and status register count fixed * table component css style changed * padding removed from table style * console removed * HCMPRE-1774: point-1 project drop down is put in the filter section and search section is not required as per last demo * fliter boundary dropdown in progress * staffName key changed for attendance mark by * bug fixes * code comment added why not used inboxsearch composer * boundary service made dynamic * boundary component made dynamic * Updated paymentStatus to review Status * Localization fixes * Localization fixes * Localization fixes * Localization fixes * fixed bill screen * Payment inbox attendance (#2103) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * removed debugger * variable name changed * tab section functionlity added * attendance register param changed * localization code and table value changed * inbox pagination and status register count fixed * table component css style changed * padding removed from table style * console removed * HCMPRE-1774: point-1 project drop down is put in the filter section and search section is not required as per last demo * fliter boundary dropdown in progress * staffName key changed for attendance mark by * bug fixes * code comment added why not used inboxsearch composer * boundary service made dynamic * boundary component made dynamic * boundary component issue fixed for mandatory filed and drop down reset * commented code removed * fixed table css * fixed api not being called again issue * added pdf and excel download options * HCMPRE-1816, HCMPRE-1774::Demo Feedbacks and Bug fixes (#2107) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * removed debugger * variable name changed * tab section functionlity added * attendance register param changed * localization code and table value changed * inbox pagination and status register count fixed * table component css style changed * padding removed from table style * console removed * HCMPRE-1774: point-1 project drop down is put in the filter section and search section is not required as per last demo * fliter boundary dropdown in progress * staffName key changed for attendance mark by * bug fixes * code comment added why not used inboxsearch composer * boundary service made dynamic * boundary component made dynamic * boundary component issue fixed for mandatory filed and drop down reset * commented code removed * bug fixes done * updated billinbox * updating session storage for billl inbox * added session storage for bill screens * fixed bill inbox screen issues * fixed my bills session issue * updated breadcrumbs * fixed date range picker component * added loader on edit screens * Ticket: HCMPRE-1822 (#2112) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * removed debugger * variable name changed * tab section functionlity added * attendance register param changed * localization code and table value changed * inbox pagination and status register count fixed * table component css style changed * padding removed from table style * console removed * HCMPRE-1774: point-1 project drop down is put in the filter section and search section is not required as per last demo * fliter boundary dropdown in progress * staffName key changed for attendance mark by * bug fixes * code comment added why not used inboxsearch composer * boundary service made dynamic * boundary component made dynamic * boundary component issue fixed for mandatory filed and drop down reset * commented code removed * bug fixes done * ticket: HCMPRE-1822, boundary option reloaded and error scenation handled for project selection and boundary selection in attendance register inbox * updated table data refresh * fixed filter issue * fixed validation issue * fixed breadcrumbs issue * fixed demo issues * ticketNo: HCMPRE-1822,bug fixes and edge cases fixed * fixed date going nulls * updated attendance duration to ceil value of dates * added session storage for selected boundary * fixed boundary filter issue * fixed locality code not going in bill search * updated render to one time only * bill search updated * fixed bill page issue * TICKET: HCMPRE-1822 (#2118) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * removed debugger * variable name changed * tab section functionlity added * attendance register param changed * localization code and table value changed * inbox pagination and status register count fixed * table component css style changed * padding removed from table style * console removed * HCMPRE-1774: point-1 project drop down is put in the filter section and search section is not required as per last demo * fliter boundary dropdown in progress * staffName key changed for attendance mark by * bug fixes * code comment added why not used inboxsearch composer * boundary service made dynamic * boundary component made dynamic * boundary component issue fixed for mandatory filed and drop down reset * commented code removed * bug fixes done * ticket: HCMPRE-1822, boundary option reloaded and error scenation handled for project selection and boundary selection in attendance register inbox * HCMPRE-1822::table rows per page issue fixed, and digit.session storage implemented * session storage fix * fixed boundary filter issue * fixed pagination issue * fixed name for approver and staff * fixed view attendance screen * added toast for bill generation * fixed owner name * fixed isRequired label * updated my bills table * reworking on the table component in view attendance screen (#2121) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * removed debugger * variable name changed * tab section functionlity added * attendance register param changed * localization code and table value changed * inbox pagination and status register count fixed * table component css style changed * padding removed from table style * console removed * HCMPRE-1774: point-1 project drop down is put in the filter section and search section is not required as per last demo * fliter boundary dropdown in progress * staffName key changed for attendance mark by * bug fixes * code comment added why not used inboxsearch composer * boundary service made dynamic * boundary component made dynamic * boundary component issue fixed for mandatory filed and drop down reset * commented code removed * bug fixes done * ticket: HCMPRE-1822, boundary option reloaded and error scenation handled for project selection and boundary selection in attendance register inbox * HCMPRE-1822::table rows per page issue fixed, and digit.session storage implemented * reworking on the tavle component in view attendance screen * demo fixes * fixed issue * fixed css issues * HCMPRE-1863:: Updated boundaryHierarchyOrder from boundary search. (#2124) HCMPRE-1863:: Updated boundaryHierarchyOrder from boundary search. Removed hardocoded boundaryType options * added project selection page * fixed approval flow * fixed bill screens * TICKET::HCMPRE-1884 (#2129) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * removed debugger * variable name changed * tab section functionlity added * attendance register param changed * localization code and table value changed * inbox pagination and status register count fixed * table component css style changed * padding removed from table style * console removed * HCMPRE-1774: point-1 project drop down is put in the filter section and search section is not required as per last demo * fliter boundary dropdown in progress * staffName key changed for attendance mark by * bug fixes * code comment added why not used inboxsearch composer * boundary service made dynamic * boundary component made dynamic * boundary component issue fixed for mandatory filed and drop down reset * commented code removed * bug fixes done * ticket: HCMPRE-1822, boundary option reloaded and error scenation handled for project selection and boundary selection in attendance register inbox * HCMPRE-1822::table rows per page issue fixed, and digit.session storage implemented * reworking on the tavle component in view attendance screen * HCMPRE-1884, worked on preselected boundary * HCMPRE-1884:: project is also bydefault selected --------- Co-authored-by: rachana-egov <[email protected]> * fixed loading screen * fixed bill inbox screen * fixed all the css issues * Inline CSS content removed from unwanted places (#2131) * attendance inbox in progress * composer in progress * inboxserach composer replaced with custom inbox component * boundary service API integration implemented for inbox screen * check box and register search API integration in progress * table data enriched * removed debugger * variable name changed * tab section functionlity added * attendance register param changed * localization code and table value changed * inbox pagination and status register count fixed * table component css style changed * padding removed from table style * console removed * HCMPRE-1774: point-1 project drop down is put in the filter section and search section is not required as per last demo * fliter boundary dropdown in progress * staffName key changed for attendance mark by * bug fixes * code comment added why not used inboxsearch composer * boundary service made dynamic * boundary component made dynamic * boundary component issue fixed for mandatory filed and drop down reset * commented code removed * bug fixes done * ticket: HCMPRE-1822, boundary option reloaded and error scenation handled for project selection and boundary selection in attendance register inbox * HCMPRE-1822::table rows per page issue fixed, and digit.session storage implemented * reworking on the tavle component in view attendance screen * HCMPRE-1884, worked on preselected boundary * HCMPRE-1884:: project is also bydefault selected * inline css code removed from custom div * css * fixed table css * added start date and end date for campaign * HCMPRE-1943:: Demo Feedback Pending Items and Fixes * Updated constants * fixed info message when boundary changes * updated css version * Revert "updated css version" This reverts commit 65129c5. * Revert "Inline CSS content removed from unwanted places (#2131)" This reverts commit 0707199. * reverted css changes * payment module * fixed project selection issue * fixed css comments * resolved github comments * resolved code rabbit comments * fixed attendance error issue * updated context path for services from global config * fixed grammer error --------- Co-authored-by: rachana-egov <[email protected]> Co-authored-by: pitabash-eGov <[email protected]> Co-authored-by: rachana-egov <[email protected]> Co-authored-by: pitabash-eGov <[email protected]> Co-authored-by: Jagankumar <[email protected]> * BUGFIX/HCMPRE-1852 :: FIxed the build config file (#2169) * BUGFIX/HCMPRE-1852 :: FIxed the build config file * Update webpack.config.js * BUGFIX/HCMPRE-2212 : Updated Facility Filter as a Multiselect dropdown (#2167) * BUGFIX.HCMPRE-2212 : Updated Facility Filter to MultiselectDropdown * fixed filter issues * Removed console logs * BUGFIX/HCMPRE-1209 : Fixed campaign summary inbetween issue (#2170) * FEATURE/HCMPRE-1438 : Updated css version for payments css (#2172) Co-authored-by: rachana-egov <[email protected]> * BUGFIX|HCMPRE-1438: payments css (#2174) * FEATURE/HCMPRE-1438 : Updated css version for payments css * fixed css issues from deployement --------- Co-authored-by: rachana-egov <[email protected]> * BUGFIX/HCMPRE-2212 : Fixed Facility Filter Issue (#2173) * ui changes and validations for boundary added (#2175) * BUGFIX|HCMPRE-1438: Updated core module version (#2176) * FEATURE/HCMPRE-1438 : Updated css version for payments css * fixed css issues from deployement * updated core modules version in payments --------- Co-authored-by: rachana-egov <[email protected]> * BUGFIX/HCMPRE-1850 : Fix the css (#2177) css version changes * FEATURE/HCMPRE-0000 : Fixed Css Issue (#2178) * FEATURE/HCMPRE-0000: adhoc fix (#2179) ? added * FEATURE/HCMPRE-1649 : help text and checklist create call order corrected (#2071) * help text and checklist create call order corrected * localisations changed --------- Co-authored-by: Jagankumar <[email protected]> * FEATURE/HCMPRE-1649: Cleanedup campaign card & added a extra info in project type selection * BUGFIX|HCMPRE-1438: Updated payments Config key (#2182) Updated paymentsConfig Key * FEATURE/HCMPRE-1649: Updated the core version to check the feature HCMPRE-1425 workbench enhancements * FEATURE/HCMPRE-2208 :: Fixed the default landing for console user * BUGFIX/HCMPRE-2243 : Showing only supported campaign types for microplan ui (#2185) * BUGFIX/HCMPRE-2243 : Showing only supported campaign types for microplan * Added review changes * Updated to hcm-microplanning module * Fixed typo * FEATURE/HCMPRE-1852: Updated the core version dynamic core module ren… (#2190) FEATURE/HCMPRE-1852: Updated the core version dynamic core module renderer & Clean up of hcm workbench module * FEATURE/HCMPRE-1852: Updated the core version as part of Core for Single landing page * BUGFIX/HCMPRE-2250 : Added loader while data is loading (#2193) BUGFIX/HCMPRE-2250 : Added loader while data is loading for the Boundary KPI * BUGFIX/HCMPRE-1852: Added missed out package dependency * BUGFIX/HCMPRE-1818: Height of FilterCard Changed (#2191) * BUGFIX/HCMPRE-2253 : Fixed Button Issue in PopDataTable Screen (#2195) * FEATURE/HCMPRE-2263: no geojson data case handled (#2197) no geojson data case handled * BUGFIX/HCMPRE-2260: upload data mapping screen add/edit bug fixes (#2199) * BUGFIX/HCMPRE-2263: Boundary Management geojson code revert (#2200) Boundary management screen geojson code revert Co-authored-by: NabeelAyubee <[email protected]> * BUGFIX/HCMPRE-2263: campaign summary cycle number issue fix (#2202) campaign summary cycle number issue fix Co-authored-by: NabeelAyubee <[email protected]> * FEATURE/HCMPRE-2296 :: add comment feature removed (#2201) * add comment feature removed * review points convered * changes * BUGFIX/HCMPRE-1820: Filter card dynamic height (#2204) * changes for filter card height * limit changed * limit changes * FEATURE/HCMPRE-2303 : Incremented campaign manager version from 0.3.0 (#2205) * FEATURE/HCMPRE-2303 : Incremented campaign manager version from 0.3.0 to 0.3.1 * removed console * added readme and change log * Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: Jagankumar <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * BUGFIX/HCMPRE-1821: Filter card tab change fix (#2206) changes * BUGFIX/HCMPRE-1438: Fixed Session storage and localization issue #2209 (#2209) Fixed Session storage and localization issue Co-authored-by: rachana-egov <[email protected]> * FEATURE/HCMPRE-2322 : Microplanning 0.2 release activities (#2210) Microplanning 0.2 release activity * BUGFIX/HCMPRE-1822: Minimum height in popInbox (#2208) changes done Co-authored-by: Nipun Arora <[email protected]> * BUGFIX/HCMPRE-2303 : Integrated with new loader (#2211) BUGFIX/HCMPRE-2303 : Integrated with new loader Co-authored-by: Jagankumar <[email protected]> * FEATURE/HCMPRE-2322 : Console 0.3.1 release activities update the logs * RELEASE/HCMPRE-1990: Updated the core & component version and updated the settings module loaders * FEATURE/HCMPRE-1438 : payment-module. Updated changelog and readme file (#2216) * Updated changelog and readme file * Update README.md --------- Co-authored-by: rachana-egov <[email protected]> * RELEASE/HCMPRE-1990 : Updated all the css versions --------- Co-authored-by: Swathi-eGov <[email protected]> Co-authored-by: suryansh-egov <[email protected]> Co-authored-by: NabeelAyubee <[email protected]> Co-authored-by: Nipun Arora <[email protected]> Co-authored-by: nabeelmd-eGov <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: abishekTa-egov <[email protected]> Co-authored-by: Swathi-eGov <[email protected]> Co-authored-by: Bhavya-egov <[email protected]> Co-authored-by: Ramkrishna-egov <[email protected]> Co-authored-by: rachana-egov <[email protected]> Co-authored-by: rachana-egov <[email protected]> Co-authored-by: pitabash-eGov <[email protected]> Co-authored-by: pitabash-eGov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose the appropriate template for your PR:
Feature PR
Feature Request
JIRA ID
Module
Description
Related Issues
Bugfix PR
Bugfix Request
JIRA ID
Module
Description
Root Cause
Related Issues
Release PR
Summary by CodeRabbit
New Features
Bug Fixes
Improvements